Merged
Conversation
Collaborator
|
Thank you! FYI to fix fmt, you can Lines 22 to 23 in 87eec43 |
blaginin
reviewed
Mar 17, 2025
Comment on lines
78
to
81
| async fn get_batches(expr: Expr, limit: usize) -> Result<Vec<RecordBatch>> { | ||
| let df = create_test_table().await?; | ||
| let df = df.select(vec![expr])?.limit(0, Some(limit))?; | ||
| df.collect().await |
Collaborator
There was a problem hiding this comment.
to fully replicate the original logic, you can also do get_batches(expr) and get_batches_with_limit(expr, limit) - that way you're reduce the magic number (10) across the codebase
Contributor
Author
There was a problem hiding this comment.
Ah yes good point, I've updated the code with your suggestion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #15245.
Rationale for this change
What changes are included in this PR?
Migrated tests in
datafusion/core/tests/dataframeto use insta.Are these changes tested?
Are there any user-facing changes?
No.