Move catalog_common out of core#15193
Merged
Weijun-H merged 4 commits intoapache:mainfrom Mar 14, 2025
Merged
Conversation
github-actions
bot
added
core
Weijun-H
reviewed
Mar 14, 2025
Member
Weijun-H
left a comment
Weijun-H
left a comment
There was a problem hiding this comment.
Thank you, @logan-keede. This PR seems to only relocate code without changing any internal logic. Wait for feedback from others.
Weijun-H
approved these changes
Mar 14, 2025
alamb
changed the title
alamb
approved these changes
Mar 14, 2025
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thanks @logan-keede and @Weijun-H -- looks good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
We can move catalog out of core now.
Deprecated Functionality Removed because DataFusion 45.0.0 is released.
What changes are included in this PR?
Are these changes tested?
Yes, as much as I could in my PC.
Are there any user-facing changes?
There should not be.
This is pretty much complete. I will just add re-exports tomorrow and do a self-review before opening for review.