Minor: Deprecate ScalarValue::raw_data #15016
Conversation
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thanks for the contirbution @qazxcdswe123
|
|
||
| // TODO: Support more types after other ScalarValue is wrapped with ArrayRef | ||
| /// Get raw data (inner array) inside ScalarValue | ||
| pub fn raw_data(&self) -> Result<ArrayRef> { |
There was a problem hiding this comment.
Thank you very much @qazxcdswe123 -- this is a nice find.
Per https://datafusion.apache.org/contributor-guide/api-health.html instead of removing this function, can you please mark it as #[deprecated] instead?
Maybe it would be a good time to go remove any deprecated functions from 41 or earlier 🤔
There was a problem hiding this comment.
Thanks for the remind!
And I think to_array is what we meant to do here?
datafusion/datafusion/common/src/scalar/mod.rs
Line 1766 in c0d53ad
There was a problem hiding this comment.
I'll file another PR to cleanup some old deprecation
qazxcdswe123
force-pushed
the
cleanup
branch
2 times, most recently
from
b35e856 to
2fcc908
Compare
alamb
changed the title
ScalarValue::raw_data
2 participants
Which issue does this PR close?
Rationale for this change
cleanup unused deadcode
What changes are included in this PR?
cleanup unused deadcode
Are these changes tested?
yes
Are there any user-facing changes?
noI just realized this is a
pub fnso if anyone is using this they may be affected. But this function does not seem to be useful?