Skip to content

Comments

refactor: replace OnceLock with LazyLock#14880

Merged
alamb merged 1 commit intoapache:mainfrom
AmosAidoo:lazy-lock
Feb 25, 2025
Merged

refactor: replace OnceLock with LazyLock#14880
alamb merged 1 commit intoapache:mainfrom
AmosAidoo:lazy-lock

Conversation

@AmosAidoo
Copy link
Contributor

Which issue does this PR close?

Rationale for this change

LazyLock is more ergonomic than OnceLock.

What changes are included in this PR?

Replaces the remaining references of OnceLock in the codebase with their LazyLock equivalents.

Are these changes tested?

Yes, by existing tests.

Are there any user-facing changes?

this commit replaces all the remaining references of
OnceLock with LazyLock
@github-actions github-actions bot added logical-expr Logical plan and expressions core Core DataFusion crate substrait Changes to the substrait crate functions Changes to functions implementation labels Feb 25, 2025
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @AmosAidoo

cc @comphead

@alamb alamb merged commit 2d57a0b into apache:main Feb 25, 2025
24 checks passed
@alamb
Copy link
Contributor

alamb commented Feb 25, 2025

This PR turns out to have gotten the 10,000th commit:

Screenshot 2025-02-25 at 3 07 21 PM

😮

@AmosAidoo
Copy link
Contributor Author

😮 So proud

@AmosAidoo AmosAidoo deleted the lazy-lock branch February 25, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate functions Changes to functions implementation logical-expr Logical plan and expressions substrait Changes to the substrait crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace OnceLock with LazyLock

2 participants