refactor: replace OnceLock with LazyLock#14870
Merged
comphead merged 2 commits intoapache:mainfrom Feb 25, 2025
Merged
Conversation
Contributor
Author
Contributor
|
Thanks @AmosAidoo -- looks like there are some fmt and clippy failures to attend to |
Contributor
Author
|
Great @alamb, I'll fix those. |
xudong963
approved these changes
Feb 25, 2025
Member
xudong963
left a comment
xudong963
left a comment
There was a problem hiding this comment.
I triggered the CI process, LGTM
comphead
approved these changes
Feb 25, 2025
Contributor
comphead
left a comment
comphead
left a comment
There was a problem hiding this comment.
thanks @AmosAidoo and @xudong963 somehow we missed it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
OnceLockwithLazyLock#11687 .Rationale for this change
LazyLock is more ergonomic than OnceLock.
What changes are included in this PR?
Replaces all OnceLock in monoticity.rs in
datafusion-functionswith their LazyLock equivalents.Are these changes tested?
Yes, by existing tests.
Are there any user-facing changes?
No