Minor: Add docs and examples for DataFusionErrorBuilder#14551
Merged
alamb merged 3 commits intoapache:mainfrom Feb 12, 2025
Merged
Minor: Add docs and examples for DataFusionErrorBuilder#14551alamb merged 3 commits intoapache:mainfrom
DataFusionErrorBuilder#14551alamb merged 3 commits intoapache:mainfrom
Conversation
github-actions
bot
added
sql
alamb
force-pushed
the
alamb/error_improvements
branch
from
79335d2 to
fc06f59
Compare
github-actions
bot
removed
sql
jonahgao
approved these changes
Feb 12, 2025
datafusion/common/src/error.rs
Outdated
| DiagnosticsIterator { head: self }.next() | ||
| } | ||
|
|
||
| /// Return an iterator this [`DataFusionError`] and any other |
Member
There was a problem hiding this comment.
Perhaps it should be "Return an iterator over this ..."?
Contributor
Author
|
Thank you very much for the review @jonahgao |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
DataFusionError::Collectionto return multipleDataFusionErrors #14439Rationale for this change
@eliaperantoni added the nice
DataFusionErrorBuilderinDataFusionError::Collectionto return multipleDataFusionErrors #14439It would be nice to have some documentation and examples on this structure to make it easier to use
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?