Skip to content

Comments

Fix build "missing field sum_value in initializer of ColumnStatistics"#14345

Merged
Rachelint merged 1 commit intoapache:mainfrom
alamb:alamb/fix_buold
Jan 29, 2025
Merged

Fix build "missing field sum_value in initializer of ColumnStatistics"#14345
Rachelint merged 1 commit intoapache:mainfrom
alamb:alamb/fix_buold

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Jan 28, 2025 •
edited by Rachelint
Loading

Which issue does this PR close?

Closes #14347

Rationale for this change

CI is failing after I merged

https://github.com/apache/datafusion/actions/runs/13018845357/job/36314586166

error[E0063]: missing field `sum_value` in initializer of `ColumnStatistics`
   --> datafusion/physical-plan/src/filter.rs:462:28
    |
462 |                     return ColumnStatistics {
    |                            ^^^^^^^^^^^^^^^^ missing `sum_value`

What changes are included in this PR?

Fix compilation

Are these changes tested?

Are there any user-facing changes?

@alamb alamb changed the title Fix build due to logical error Fix build due to missing field sum_value in initializer of ColumnStatistics`` Jan 28, 2025
@github-actions github-actions bot added the physical-expr Changes to the physical-expr crates label Jan 28, 2025
@alamb alamb changed the title Fix build due to missing field sum_value in initializer of ColumnStatistics`` Fix build due to missing field sum_value in initializer of ColumnStatistics Jan 28, 2025
@alamb alamb changed the title Fix build due to missing field sum_value in initializer of ColumnStatistics Fix build "missing field sum_value in initializer of ColumnStatistics" Jan 28, 2025
@alamb alamb mentioned this pull request Jan 28, 2025
Merged
@alamb
Copy link
Contributor Author

alamb commented Jan 28, 2025

Thank you for the quick review @findepi -- I will merge this once it passes tests

@Omega359
Copy link
Contributor

Omega359 commented Jan 28, 2025

I actually saw this in the extended tests ... I am watching those :)

@buraksenn buraksenn mentioned this pull request Jan 28, 2025
Closed
@adriangb
Copy link
Contributor

adriangb commented Jan 29, 2025

Thank you for the quick fix!

Rachelint
Rachelint approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@Rachelint Rachelint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @alamb

@Rachelint
Copy link
Contributor

Rachelint commented Jan 29, 2025

All tests seem passed, let's merge and fix it.

@Rachelint Rachelint merged commit 66b4da2 into apache:main Jan 29, 2025
26 of 30 checks passed
@alamb
Copy link
Contributor Author

alamb commented Jan 29, 2025

Thank you for the quick fix!

Well, I also broke it 😆

I don't want to be lauded as a fire fighter if I was also the one starting the fires 😆 🚒

I saw this a few times in my past lives and it is the wrong incentive

@alamb alamb deleted the alamb/fix_buold branch January 29, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@findepi findepi findepi approved these changes

@adriangb adriangb adriangb approved these changes

@Rachelint Rachelint Rachelint approved these changes

Assignees

No one assigned

Labels

physical-expr Changes to the physical-expr crates

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Ci broken due to field missing of ColumnStatistics

5 participants

@alamb @Omega359 @adriangb @Rachelint @findepi