add tests to check precision loss fix#14284
Merged
alamb merged 5 commits intoapache:mainfrom Jan 27, 2025
Merged
Conversation
Contributor
|
Thanks @himadripal I started the CI checks on this PR |
Contributor
Author
|
Thank you @alamb. Removed the |
Contributor
Author
|
#13492 fix for this is in arrow-rs and this is a test to confirm the fix. |
alamb
approved these changes
Jan 26, 2025
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @himadripal -- this looks great to me
suggestions from Andrew Co-authored-by: Andrew Lamb <[email protected]>
Contributor
|
I pushed a small fix to this branch to get it to compile |
Contributor
|
Thanks again @himadripal |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
apache/datafusion-comet#375
Closes #.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?