fix: run sqllogictest with complete#14254
Conversation
|
I don't think this is the correct solution, at least without adding another 'parent' slt that just includes join.slt.part. |
that will put join.slt in the same parallel state(as mentioned in #12752) and cause complication, so I will try to fix that first. |
|
cc @Omega359 PS: forgot to add changes to postgres 😞 |
|
I'll do my best to find time today to review this |
|
@Omega359 with risinglightdb/sqllogictest-rs#249 , I think we can merge this PR to completely resolve #12752 |
|
LGTM @logan-keede - thanks for following this through to completion! |
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @logan-keede and @Omega359
I also made a change to join.slt and ran this locally and it worked great 🎉
3 participants
Which issue does this PR close?
Closes at least a part of #12752
Rationale for this change
Error completing "join.slt" seems to be stemming fro the fact that datafusion/sqllogictest/test_files/join_disable_repartition_joins.slt seems to be including it but it is not a part file so it fails to do so.
What changes are included in this PR?
rename join.slt to join.slt.part
Are these changes tested?
ran
cargo test --test sqllogictests -- --completewith 3 error instead of 4.Are there any user-facing changes?
no