consolidation of examples: date_time_functions #14240
Conversation
|
Thanks @logan-keede triggering the run |
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @logan-keede -- this looks like a great improvement to me ❤️
FYI @Omega359 as I think you contributed many of these examples originally
alamb
changed the title
comphead
left a comment
comphead
left a comment
There was a problem hiding this comment.
thanks @logan-keede for removing also to_char.rs I doubled checked it and it refers to conversion from dates so it perfectly fits to date and time examples
thanks, but credit for noticing that that goes to @alamb for mentioning it in #7013 (comments) |
lol all I do now it seems is to write tickets |
3 participants
Which issue does this PR close?
Rationale for this change
All functions are related to date_time functionality, it is easier to navigate if they are together.
assertions allow us to view expected output without running, can also serve as partial tests.
as mentioned in #13939 by @comphead
What changes are included in this PR?
Are these changes tested?
No. just examples.
Are there any user-facing changes?
No.