Deprecate max statistics size properly#14188
Merged
alamb merged 8 commits intoapache:mainfrom Jan 25, 2025
Merged
Conversation
alamb
approved these changes
Jan 18, 2025
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
This looks good to me -- thank you @logan-keede
|
|
||
| /// (writing) Sets max statistics size for any column. If NULL, uses | ||
| /// default parquet writer setting | ||
| /// max_statistics_size is deprecated, currently it is not being used |
Contributor
|
I pushed another commit for |
Contributor
Author
Can I ask for the rationale is it just good practice or was it compiler giving warnings? (I am relatively new to rust.) |
Contributor
The compiler was erroring. For example that is why this CI was failing |
github-actions
bot
added
the
documentation
Contributor
Author
|
I thought this was done, apparently not. Please review the changes and let me know if we need to make more changes before merging this PR. @alamb |
Contributor
|
Thanks again @logan-keede |
This was referenced Feb 11, 2025
38 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #14172
Rationale for this change
Mark
max_size_statisticsdeprecatedWhat changes are included in this PR?
Are these changes tested?
builds properly, no functional changes
Are there any user-facing changes?
not yet.