Remove partition_mode parameter from HashJoinExec::swap_inputs#13940
Closed
alamb wants to merge 1 commit intoapache:mainfrom
Closed
Remove partition_mode parameter from HashJoinExec::swap_inputs#13940alamb wants to merge 1 commit intoapache:mainfrom
alamb wants to merge 1 commit intoapache:mainfrom
Conversation
github-actions
bot
added
physical-expr
Contributor
Author
|
Seems there are unit tests (though no end to end tests) that fail without this parameter. I am not sure why |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Test out the question of "why bother to pass this parameter" from @berkaysynnada on #13910 (comment)
What changes are included in this PR?
1, Remove partition_mode parameter from HashJoinExec::swap_inputs
Are these changes tested?
By CI
Are there any user-facing changes?