Skip to content

feat(substrait): remove dependency on datafusion default features #13594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 2 commits into from
Dec 4, 2024
Merged

feat(substrait): remove dependency on datafusion default features #13594

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c298af
feat(substrait): remove dependency on datafusion default features
notfilippo Nov 28, 2024
cd181c1
ci(substrait): check without default features
notfilippo Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,9 +80,12 @@ jobs:
- name: Check datafusion-common without default features
run: cargo check --all-targets --no-default-features -p datafusion-common

- name: Check datafusion-functions
- name: Check datafusion-functions without default features
run: cargo check --all-targets --no-default-features -p datafusion-functions

- name: Check datafusion-substrait without default features
run: cargo check --all-targets --no-default-features -p datafusion-substrait

- name: Check workspace in debug mode
run: cargo check --all-targets --workspace

Expand Down Expand Up @@ -603,4 +606,4 @@ jobs:
run: cargo msrv --output-format json --log-target stdout verify
- name: Check datafusion-cli
working-directory: datafusion-cli
run: cargo msrv --output-format json --log-target stdout verify
run: cargo msrv --output-format json --log-target stdout verify
4 changes: 3 additions & 1 deletion datafusion/substrait/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ arrow-buffer = { workspace = true }
async-recursion = "1.0"
async-trait = { workspace = true }
chrono = { workspace = true }
datafusion = { workspace = true, default-features = true }
datafusion = { workspace = true }
itertools = { workspace = true }
object_store = { workspace = true }
pbjson-types = "0.7"
Expand All @@ -51,4 +51,6 @@ serde_json = "1.0"
tokio = { workspace = true }

[features]
default = ["physical"]
physical = ["datafusion/parquet"]
protoc = ["substrait/protoc"]
1 change: 1 addition & 0 deletions datafusion/substrait/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@
//! ```
pub mod extensions;
pub mod logical_plan;
#[cfg(feature = "physical")]
pub mod physical_plan;
pub mod serializer;
pub mod variation_const;
Expand Down
1 change: 1 addition & 0 deletions datafusion/substrait/tests/cases/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ mod emit_kind_tests;
mod function_test;
mod logical_plans;
mod roundtrip_logical_plan;
#[cfg(feature = "physical")]
mod roundtrip_physical_plan;
mod serialize;
mod substrait_validations;