Move Pruning into physical-optimizer crate#13485
Merged
jayzhan211 merged 4 commits intoapache:mainfrom Nov 20, 2024
Merged
Conversation
alamb
reviewed
Nov 19, 2024
Comment on lines
41
to
42
| datafusion-expr = { workspace = true, default-features = true } | ||
| datafusion-functions-nested = { workspace = true } |
Contributor
There was a problem hiding this comment.
Can you please move datafusion-functions-nested to dev-dependencies?
I also think we can avoid the dependency on datafusion-expr by changing
use datafusion_expr::Operator;to
use datafusion_expr_common::operator::Operator;|
|
||
| [dependencies] | ||
| arrow = { workspace = true } | ||
| arrow-array = { workspace = true } |
Contributor
There was a problem hiding this comment.
If possible, can you avoid this explicit dependency? Whatever is used in arrow-array should be available in arrow and then we can keep the dependency chain simpler
irenjj
commented
Nov 19, 2024
| @@ -22,12 +22,10 @@ | |||
| use std::collections::HashSet; | |||
Contributor
Author
There was a problem hiding this comment.
datafusion-expr dependency is needed by //! [Expr]: crate::prelude::Expr, should we remove the comment to avoid introducing new dependencies? @alamb
Contributor
There was a problem hiding this comment.
In other places, we have changed the link to docs.rs directly. So in this case, change the link to
irenjj
commented
Nov 19, 2024
| recursive = { workspace = true } | ||
|
|
||
| [dev-dependencies] | ||
| datafusion-expr = { workspace = true } |
Contributor
This was referenced Jan 10, 2025
This was referenced Jan 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
part of #11502.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?