Closed
Conversation
github-actions
bot
added
sqllogictest
alamb
force-pushed
the
alamb/crypto_function_errors
branch
from
1981d95 to
fcedd41
Compare
This was referenced Nov 15, 2024
Omega359
added a commit
to Omega359/arrow-datafusion
that referenced
this pull request
Nov 20, 2024
alamb
pushed a commit
that referenced
this pull request
Nov 20, 2024
* Fix md5 return_type to only return Utf8 as per current code impl. * Added tests from #13443 to verify fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests that show
Dictionaryarrays such asmd5#13444Which issue does this PR close?
Follow on to #13407
Rationale for this change
While looking at #13407 from @Omega359 I figured I would add a few more tests of the functions actually running .
What changes are included in this PR?
Add tests using the wonderful string_part.slt framework from @goldmedal to test running the functions on all the different types of strings
Are these changes tested?
Only tests
Are there any user-facing changes?