Fix Binary & Binary View Unparsing#13427
Merged
alamb merged 4 commits intoapache:mainfrom Nov 18, 2024
Merged
Conversation
* Skip casting to binary when inner expr is value * Update datafusion/sql/src/unparser/expr.rs Co-authored-by: Jack Eadie <[email protected]> --------- Co-authored-by: Jack Eadie <[email protected]>
alamb
approved these changes
Nov 15, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thanks @Sevenannn -- this makes sense to me. I have some small suggestions but I don't think they are needed to merge this PR
Comment on lines
+2181
to
+2186
| Expr::Cast(Cast { | ||
| expr: Box::new(Expr::Literal(ScalarValue::Utf8(Some( | ||
| "blah".to_string(), | ||
| )))), | ||
| data_type: DataType::Binary, | ||
| }), |
Contributor
There was a problem hiding this comment.
I think you can write this more concisely with lit
Suggested change
| Expr::Cast(Cast { | |
| expr: Box::new(Expr::Literal(ScalarValue::Utf8(Some( | |
| "blah".to_string(), | |
| )))), | |
| data_type: DataType::Binary, | |
| }), | |
| Expr::Cast(Cast { | |
| expr: Box::new(lit("blah")) | |
| data_type: DataType::Binary, | |
| }), |
You could also try to use https://docs.rs/datafusion/latest/datafusion/logical_expr/enum.Expr.html#method.cast_to but that requires a valid schema
phillipleblanc
approved these changes
Nov 18, 2024
Contributor
|
🚀 |
Contributor
|
Thanks @Sevenannn @phillipleblanc and @Jeadie |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Datafusion enforces an eager cast of value to
Binary/BinaryViewvalue in the logical plan where a comparison with binary value is presented. For example, in the following planFilter: value = CAST(Utf8("binary_value") AS BinaryHowever, when using unparser to convert the plan back to sql, where the sql will be sent to various query engine (e.g. DuckDB). the cast is not needed for the value, in the example above the value "binary_value", since the raw value can be directly used in SQL engines without casting to an engine specific dictionary type. Therefore, the plan can simply be rewritten into where value = 'binary_value'
What changes are included in this PR?
cast_to_sql, which directly pass inner_expr instead of cast inner_expr when casting to binary / binaryview / dictionary in the Expr::Cast, and keep the original casting logic in all other cases.Are these changes tested?
Yes
Are there any user-facing changes?
No