parquet:Add file_extension for specify file_extension of ParquetReadOptions#13353
Merged
alamb merged 2 commits intoapache:mainfrom Nov 14, 2024
Merged
Conversation
alamb
approved these changes
Nov 13, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @glfeng318 -- this looks like a nice improvement to me
Contributor
Author
|
cargo fmt check failed and i had removed the whitespace in line 270 |
findepi
approved these changes
Nov 13, 2024
Member
findepi
left a comment
findepi
left a comment
There was a problem hiding this comment.
Makes sense.
Curious, is the only use-case to set this to ""?
Contributor
Author
|
No, |
Contributor
|
Thanks again @glfeng318 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
This allows users to specify the file extendsion in ParquetReadOptions
What changes are included in this PR?
add a new fn
file_extensionfor ParquetReadOptionsAre these changes tested?
tests covered by existing tests
Are there any user-facing changes?