[minor] overload from_unixtime func to have optional timezone parameter#13130
[minor] overload from_unixtime func to have optional timezone parameter#13130berkaysynnada merged 8 commits intoapache:mainfrom
Conversation
github-actions
bot
added
documentation
jonathanc-n
left a comment
jonathanc-n
left a comment
There was a problem hiding this comment.
This LGTM! Thank you very much
|
I can probably finish the rest of the issue in another pr after this is merged |
Co-authored-by: Bruce Ritchie <[email protected]>
|
I took the liberty of merging this PR up from main to resolve a conflict |
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thanks @buraksenn -- I am marking this PR as draft as it is no longer waiting on review (and I am trying to clear the review queue)
I did merge again from main to fix the compile error
Thanks for the review. I've fixed the issue and added test cases to timestamps.slt. I'm converting it to Ready for review again |
berkaysynnada
left a comment
berkaysynnada
left a comment
There was a problem hiding this comment.
LGTM, thank you @buraksenn
5 participants
Which issue does this PR close?
Not closes but discussed in #12892
Rationale for this change
from_unixtime is not aware of timezone so this PR makes it have optional timezone parameter
What changes are included in this PR?
code,test,doc change for overloaded from_unixtime
Are these changes tested?
yes added tests
Are there any user-facing changes?
yes