Skip to content

Comments

Optimize signum function (3-25x faster)#12890

Merged
alamb merged 2 commits intoapache:mainfrom
simonvandel:optimize-signum
Oct 14, 2024
Merged

Optimize signum function (3-25x faster)#12890
alamb merged 2 commits intoapache:mainfrom
simonvandel:optimize-signum

Conversation

@simonvandel
Copy link
Contributor

@simonvandel simonvandel commented Oct 12, 2024

Which issue does this PR close?

Didn't create an issue beforehand.

Rationale for this change

Same idea as #12881. Using the unary functions allow faster processing (most likely auto-vectorized code) by avoiding branching on nulls.

What changes are included in this PR?

  • Add bench
  • Apply unary

Are these changes tested?

Yes, with existing tests.

Are there any user-facing changes?

Yes, faster signum:

signum f32 array: 1024  time:   [419.68 ns 420.68 ns 421.84 ns]
                        change: [-93.679% -93.655% -93.628%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
  3 (3.00%) high mild
  4 (4.00%) high severe

signum f64 array: 1024  time:   [1.1809 µs 1.1822 µs 1.1835 µs]
                        change: [-81.672% -81.630% -81.593%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
  4 (4.00%) high mild
  1 (1.00%) high severe

signum f32 array: 4096  time:   [1.1124 µs 1.1137 µs 1.1153 µs]
                        change: [-96.060% -96.049% -96.039%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 8 outliers among 100 measurements (8.00%)
  6 (6.00%) high mild
  2 (2.00%) high severe

signum f64 array: 4096  time:   [5.4527 µs 5.4624 µs 5.4725 µs]
                        change: [-80.223% -80.176% -80.125%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
  4 (4.00%) high mild

signum f32 array: 8192  time:   [2.2937 µs 2.2959 µs 2.2983 µs]
                        change: [-96.218% -96.199% -96.181%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 2 outliers among 100 measurements (2.00%)
  1 (1.00%) high mild
  1 (1.00%) high severe

signum f64 array: 8192  time:   [15.455 µs 15.534 µs 15.630 µs]
                        change: [-75.051% -74.722% -74.440%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
  4 (4.00%) high mild
  1 (1.00%) high severe

@github-actions github-actions bot added the functions Changes to functions implementation label Oct 12, 2024
jonahgao
jonahgao approved these changes Oct 12, 2024
View reviewed changes
Copy link
Member

@jonahgao jonahgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@findepi
Copy link
Member

findepi commented Oct 12, 2024

Are we going to remove all usages of make_function_scalar_inputs_return_type?

@simonvandel
Copy link
Contributor Author

simonvandel commented Oct 12, 2024

Are we going to remove all usages of make_function_scalar_inputs_return_type?

If the replacement always has same or better performance, I don't see why not

@findepi
Copy link
Member

findepi commented Oct 12, 2024

Makes sense to me!
If this is an already established knowledge that replacing make_function_scalar_inputs_return_type with unary is an improvement, I don't see a need to benchmark this every time separately. IMO we could just do this change everywhere where the code pattern is same.

@simonvandel
Copy link
Contributor Author

simonvandel commented Oct 13, 2024

I don't mind adding the benchmarks, since they

  • are easy to add
  • will benefit the next contributor wanting to try some optimizations
  • motivate me by quantifying performance of the changes I make

@alamb alamb merged commit 746380b into apache:main Oct 14, 2024
@alamb
Copy link
Contributor

alamb commented Oct 14, 2024

🚀 looking very nice 👌

@alamb
Copy link
Contributor

alamb commented Oct 14, 2024

Are we going to remove all usages of make_function_scalar_inputs_return_type?

Perhaps it could be a nice ticket to file / project ti organize

@findepi findepi mentioned this pull request Oct 14, 2024
Closed
@findepi
Copy link
Member

findepi commented Oct 14, 2024

Are we going to remove all usages of make_function_scalar_inputs_return_type?

Perhaps it could be a nice ticket to file / project ti organize

filed #12923

hailelagi pushed a commit to hailelagi/datafusion that referenced this pull request Oct 14, 2024
@simonvandel @hailelagi
Optimize signum function (3-25x faster) (apache#12890)
9a13d07 
* add bench

* optimize signum
@buraksenn buraksenn mentioned this pull request Oct 16, 2024
Merged
@alamb alamb mentioned this pull request Oct 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@findepi findepi findepi approved these changes

@jonahgao jonahgao jonahgao approved these changes

Assignees

No one assigned

Labels

functions Changes to functions implementation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@simonvandel @findepi @alamb @jonahgao