Macro for creating record batch from literal slice#12846
Conversation
|
Maybe this is worth moving upstream to arrow-rs as well |
timsaucer
force-pushed
the
tsaucer/memtable-creation-macro
branch
from
50dfc06 to
9d6c45a
Compare
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
😍 Thanks @timsaucer
I think it would be worth filing a ticket to port this upstream to arrow-rs eventually FWIW
| }; | ||
| } | ||
|
|
||
| /// Creates a record batch from literal slice of values, suitable for rapid |
There was a problem hiding this comment.
this is beautiful. We can probably use it to clean up a bunch of the testing setup as well
| (Float64, $values: expr) => { | ||
| std::sync::Arc::new(arrow::array::Float64Array::from($values)) | ||
| }; | ||
| (Utf8, $values: expr) => { |
There was a problem hiding this comment.
There are a bunch of other types that might be worth supporting too LargeUtf8, Utf8View, etc
Full list here:
https://docs.rs/arrow/latest/arrow/datatypes/enum.DataType.html
We could definitely do it as a follow on PR
datafusion/common/src/test_util.rs
Outdated
| ("c", Utf8, vec!["alpha", "beta", "gamma"]) | ||
| ); | ||
|
|
||
| assert!(batch.is_ok()); |
There was a problem hiding this comment.
should we assert the contents too?
datafusion/common/src/test_util.rs
Outdated
| let batch = create_batch!( | ||
| ("a", Int32, vec![1, 2, 3]), | ||
| ("b", Float64, vec![Some(4.0), None, Some(5.0)]), | ||
| ("c", Utf8, vec!["alpha", "beta", "gamma"]) | ||
| ); |
| /// ("c", Utf8, vec!["alpha", "beta", "gamma"]) | ||
| /// ); | ||
| /// ``` | ||
| #[macro_export] |
There was a problem hiding this comment.
does this affect how the macro is imported? do we need this?
There was a problem hiding this comment.
I think we do need it so we can use it in downstream repos as well.
|
I put in a couple of small additions per feedback here and on the arrow-rs issue. |
|
Thanks agian -- this looks great |
* Add macro for creating record batch, useful for unit test or rapid development * Update docstring * Add additional checks in unit test and rename macro per user input
3 participants
Which issue does this PR close?
Closes #12574
Rationale for this change
This macro allows for easy creation of a record batch, useful for prototype and unit testing. A user requested this feature.
What changes are included in this PR?
Adds a macro to create a record batch. For example, the following creates a record batch with three arrays, a non nullable Int32, a nullable Float64, and a non nullable String.
Yields:
Are these changes tested?
Tested both in the provided unit test and locally.
Are there any user-facing changes?
No