LexRequirement as a struct, instead of a type#12583
Merged
alamb merged 4 commits intoapache:mainfrom Sep 23, 2024
Merged
Conversation
github-actions
bot
added
physical-expr
ngli-me
changed the title
berkaysynnada
approved these changes
Sep 23, 2024
Contributor
berkaysynnada
left a comment
berkaysynnada
left a comment
There was a problem hiding this comment.
LGTM, thank you @ngli-me
| @@ -264,9 +267,55 @@ pub type LexOrdering = Vec<PhysicalSortExpr>; | |||
| /// a reference to a lexicographical ordering. | |||
| pub type LexOrderingRef<'a> = &'a [PhysicalSortExpr]; | |||
Contributor
There was a problem hiding this comment.
Perhaps we could follow a similar pattern for LexOrderingRef, too.
Contributor
Author
There was a problem hiding this comment.
Created a separate issue for this, #12591!
Contributor
There was a problem hiding this comment.
BTW having a real struct will make printing these structures much easier -- e.g. I had to do some akward workarounds to implement Display or LexOrdering in #12590
…ement was not being converted after the merge.
Contributor
Author
|
Made some adjustments, since there was a merge conflict :) |
alamb
approved these changes
Sep 23, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Love it -- thank you @ngli-me and @berkaysynnada
bgjackma
pushed a commit
to bgjackma/datafusion
that referenced
this pull request
Sep 25, 2024
* Converted LexRequirement into a struct. * Adjusted the wrapping to return the correct type, since the LexRequirement was not being converted after the merge. --------- Co-authored-by: nglime <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #12255.
Rationale for this change
What changes are included in this PR?
Converted LexRequirement type into a struct, with the
Vec<PhysicalSortRequirement>as the field labeledinner.Added two functions for convenience, an
iterandpushfunction relating to the struct field.Added implementations for
Deref,FromIteratorandIntoIterator.Are these changes tested?
Adjusted the existing tests
Are there any user-facing changes?
The
Vec<PhysicalSortRequirement>needs to be wrapped to initialize the struct insance, and some of the usage needs to be adjusted to get the field from the struct.