Fix unparsing offset#12539
Merged
alamb merged 1 commit intoapache:mainfrom Sep 20, 2024
Stazer:fix-unparsing-offset
Merged
Conversation
phillipleblanc
approved these changes
Sep 20, 2024
Contributor
phillipleblanc
left a comment
phillipleblanc
left a comment
There was a problem hiding this comment.
Looks great, thanks!
alamb
approved these changes
Sep 20, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @Stazer and @phillipleblanc for the reivew
Contributor
|
Looks like there are some small CI failures on this PR |
Contributor
|
🚀 -- thanks again |
sgrebnov
pushed a commit
to spiceai/datafusion
that referenced
this pull request
Oct 23, 2024
sgrebnov
added a commit
to spiceai/datafusion
that referenced
this pull request
Oct 24, 2024
* init (apache#12453) * Fix unparse table scan with the projection pushdown (apache#12534) * unparse the projection base on the source schema * refactor and enhance the test * Fix unparsing OFFSET (apache#12539) * Unparse Sort with pushdown limit to SQL string (apache#12873) * unparse Sort with push down limit * cargo fmt * set query limit directly * Unparse `SubqueryAlias` without projections to SQL (apache#12896) * change pub function comment to doc * unparse subquery alias without projections * fix tests * rollback the empty line * rollback the empty line * exclude the table_scan with pushdown case * fmt and clippy * simplify the ast to string and remove unused debug code * enhance unparsing plan with pushdown to avoid unnamed subquery (apache#13006) * Update --------- Co-authored-by: Lordworms <[email protected]> Co-authored-by: Jax Liu <[email protected]> Co-authored-by: Justus Flerlage <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #12538.
Rationale for this change
What changes are included in this PR?
I have added a missing block for unparsing OFFSET.
Are these changes tested?
Yes. Unit-Tests are provided.
Are there any user-facing changes?
No.