support EXTRACT on intervals and durations#12514
Merged
alamb merged 1 commit intoapache:mainfrom Sep 20, 2024
Merged
Conversation
github-actions
bot
added
sqllogictest
alexmojaki
reviewed
Sep 19, 2024
Signed-off-by: Nick Cameron <[email protected]>
nrc
force-pushed
the
interval-extract-2
branch
from
2d4732d to
3f91868
Compare
Contributor
Author
|
Null handling and tests addressed. It took a tiny bit more code to make @alamb ready for re-review, thanks! |
alamb
approved these changes
Sep 20, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Looks great -- thank you @nrc and @samuelcolvin and @alexmojaki
| })?; | ||
| Ok(Arc::new(r)) | ||
| } else { | ||
| // Nulls in secs are preserved, nulls in subsecs are treated as zero to account for the case |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6327.
Closes #7097
What changes are included in this PR?
Support
extract/date_partby passing through requests to Arrow (where functionality was added in apache/arrow-rs#6071 and apache/arrow-rs#6246). There were also two changes required to thesecondshelper function:A change which would fix both these issues (and I assume is an invariant which previously held) would be to not include whole seconds when returning nanoseconds. However, I think that breaks compat with Postgres.
Are these changes tested?
Yes, sqllogictests. The tests are not exhaustive because these features are properly tested in Arrow.
Are there any user-facing changes?
Users can use
extractordate_partwith intervals and durations.