Minor: add ListingOptions::with_file_extension_opt#12461
Merged
comphead merged 2 commits intoapache:mainfrom Sep 14, 2024
Merged
Minor: add ListingOptions::with_file_extension_opt#12461comphead merged 2 commits intoapache:mainfrom
ListingOptions::with_file_extension_opt#12461comphead merged 2 commits intoapache:mainfrom
Conversation
comphead
approved these changes
Sep 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to #12378
Rationale for this change
While working with @waruto210 on #12417, we noticed this API would make the code easier to work with.
What changes are included in this PR?
Add
ListingOptions::with_file_extension_optAre these changes tested?
Yes, by doc test example that is run in CI
Are there any user-facing changes?
New API, no breaking changes