feat: Add DateFieldExtractStyle::Strftime support for SqliteDialect unparser#12161
Merged
alamb merged 4 commits intoapache:mainfrom Sep 3, 2024
peasee:feat/sqlite-strftime-support
Merged
feat: Add DateFieldExtractStyle::Strftime support for SqliteDialect unparser#12161alamb merged 4 commits intoapache:mainfrom peasee:feat/sqlite-strftime-support
alamb merged 4 commits intoapache:mainfrom
peasee:feat/sqlite-strftime-support
Conversation
devinjdangelo
approved these changes
Aug 29, 2024
alamb
changed the title
Contributor
Thanks @devinjdangelo -- sorry for the delay, I was out last week and am catching up |
alamb
approved these changes
Sep 2, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
The code looks good to me too -- thank you @peasee and @devinjdangelo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #12160
Rationale for this change
strftime. The unparser needs to be updated to supportstrftime, as any other scalar function results in SQLite query errors.What changes are included in this PR?
DateFieldExtractStylefor SQLite toStrftimeDateFieldExtractStyle::Strftimeto usestrftimeinstead ofdate_partAre these changes tested?
Yes
Are there any user-facing changes?
No?