Add generate_series tests for arrays#11921
Merged
alamb merged 2 commits intoapache:mainfrom Aug 9, 2024
Merged
Conversation
alamb
force-pushed
the
alamb/add_generate_series_tests
branch
from
47e0579 to
4eb7c29
Compare
This was referenced Aug 9, 2024
alamb
commented
Aug 9, 2024
alamb
changed the title
generate_series tests for arrays
tshauck
approved these changes
Aug 9, 2024
Contributor
tshauck
left a comment
tshauck
left a comment
There was a problem hiding this comment.
LGTM! I'll check out these tests relative to my PR, but if/when you wanna merge, I can rebase too.
comphead
reviewed
Aug 9, 2024
| [1989-04-01, 1990-04-01, 1991-04-01, 1992-04-01] | ||
|
|
||
|
|
||
| # https://github.com/apache/datafusion/issues/11922 |
comphead
approved these changes
Aug 9, 2024
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #11823
Part of #11922
Rationale for this change
While reviewing #11907 from @tshauck I didn't see any tests for running generate_series with actual input arrays, the current tests only handled constants
What changes are included in this PR?
Add tests for
generate_serieswith columnsAre these changes tested?
Only tests
Are there any user-facing changes?