fix: hash join tests with forced collisions#11806
Merged
alamb merged 4 commits intoapache:mainfrom Aug 6, 2024
Merged
Conversation
comphead
reviewed
Aug 5, 2024
| // With hash collisions enabled, all records will match each other | ||
| // and filtered later. | ||
| // Expected number of matches = 9 | ||
| div_ceil(9, batch_size) |
Contributor
There was a problem hiding this comment.
just wondering will it be 9 for all batch sizes?
Contributor
Author
There was a problem hiding this comment.
Yes, since create_hashes always sets 0 as hash values, with force-collisions feature enabled, the total number of hash table matches will be equal to left.row_count() * right.row_count() for each batch size. The result of the output batch count calculation depends on the batch size though, and it's based on the number of matches.
alamb
approved these changes
Aug 5, 2024
Co-authored-by: Andrew Lamb <[email protected]>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #11658.
Rationale for this change
Some tests in
hash_join.rscheck the number of output batches, and since output batch forHashJoinExecis created while matching join keys against hash table built on build-side data (which includes only matching by hashes, comparing actual values is a next step in join execution), these tests are failing with forced collisions (due to equal hashes, all records are considered as matching).This PR recovers hash join tests by adjusting the numbers of expected batches in case test is running with
force_hash_collisionsfeature.What changes are included in this PR?
Different numbers of expected output batches for
force_hash_collisionsfeature in hash join tests.Are these changes tested?
Yes
Are there any user-facing changes?
No