Support LogicalPlan Debug differently than Display#11774
Merged
alamb merged 5 commits intoapache:mainfrom Aug 4, 2024
Merged
Conversation
github-actions
bot
added
sql
alamb
changed the title
LogicalPlan Debug differently than Display
alamb
approved these changes
Aug 2, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Nice! Thank you @lewiszlw -- I think this is a very nice improvement
My understanding of this change (for other reviewers) is:
- previously
"{plan:?}"and"{plan}"(akaDebugandDisplayprinting) printed out the display version - After this change
"{plan:?}"prints out a more standard rust debug style with fields, etc. and the"{plan}"remains unchangd
Contributor
|
Thanks again @lewiszlw |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
LogicalPlan implemented Debug with actual display output. It's not useful for debugging some node/expr details.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?