Replace println! with assert! if possible in DataFusion examples#11237
Merged
alamb merged 6 commits intoapache:mainfrom Jul 5, 2024
Nishi46:nishi_branch
Merged
Replace println! with assert! if possible in DataFusion examples#11237alamb merged 6 commits intoapache:mainfrom Nishi46:nishi_branch
alamb merged 6 commits intoapache:mainfrom
Nishi46:nishi_branch
Conversation
Member
|
please run |
alamb
reviewed
Jul 5, 2024
| "Optimized Logical Plan:\n\n{}\n", | ||
| logical_plan.display_indent() | ||
| assert_eq!( | ||
| logical_plan.display_indent().to_string(), |
Contributor
There was a problem hiding this comment.
this actual plan is quite a bit more complicated than shown here
alamb
reviewed
Jul 5, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you for this contribution @Nishi46
The examples in rewrite_expr.rs are being split up (see #11085) so in order to help this PR along, I pushed some commits to the relevant tests.
Once this PR is merged I think subsequent PRs will be easer to get in because CI will run automatically for you
If you want to keep helping out here (and I hope that you do!) perhaps you can make multiple PRs, one for each example? I think that will also help get the code in sooner rather than later
Contributor
comphead
pushed a commit
to comphead/arrow-datafusion
that referenced
this pull request
Jul 8, 2024
…che#11237) * Replace println! with assert! if possible in DataFusion examples * Replace println! with assert! if possible in DataFusion examples * Update rewrite_expr.rs * port changes to other examples --------- Co-authored-by: Andrew Lamb <[email protected]>
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
…che#11237) * Replace println! with assert! if possible in DataFusion examples * Replace println! with assert! if possible in DataFusion examples * Update rewrite_expr.rs * port changes to other examples --------- Co-authored-by: Andrew Lamb <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of Closes #11230