Implement user defined planner for extract#11215
Merged
alamb merged 2 commits intoapache:mainfrom Jul 3, 2024
Merged
Conversation
13 tasks
alamb
approved these changes
Jul 2, 2024
Contributor
alamb
left a comment
There was a problem hiding this comment.
I merged this PR up from main to resolve some conflicts
Contributor
|
Thanks again @xinlifoobar |
Contributor
|
I just reset my branch with upstream main just now and I'm getting this in 4 of my tests: Is there some required changes to supporting code to facilitate the changes in this issue? |
Contributor
|
Adding this clause to the plan_to_sql.rs:roundtrip_expr() test showcases the issue: |
Contributor
|
The issue boils down to SqlToRel::new_with_options(..) not setting the planners. Unfortunately, I can't find a way to retrieve the list of planners set on the context to set them myself - I'll file a ticket for that shortly. |
Contributor
comphead
pushed a commit
to comphead/arrow-datafusion
that referenced
this pull request
Jul 8, 2024
Co-authored-by: Andrew Lamb <[email protected]>
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
Co-authored-by: Andrew Lamb <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #11207 and closes #11220
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?