Skip to content

Implement is [not] distinct from#1117

Merged
Dandandan merged 2 commits intoapache:masterfrom
Dandandan:isdistinctfrom
Oct 15, 2021
Merged

Implement is [not] distinct from#1117
Dandandan merged 2 commits intoapache:masterfrom
Dandandan:isdistinctfrom

Conversation

@Dandandan
Copy link
Contributor

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added datafusion sql SQL Planner labels Oct 14, 2021
@Dandandan Dandandan marked this pull request as draft October 14, 2021 17:17
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍

@Dandandan Dandandan force-pushed the isdistinctfrom branch 3 times, most recently from b3dc2c1 to 69582dd Compare October 15, 2021 06:46
@Dandandan Dandandan closed this Oct 15, 2021
@Dandandan Dandandan reopened this Oct 15, 2021
@Dandandan Dandandan marked this pull request as ready for review October 15, 2021 06:54
@Dandandan Dandandan changed the title [WIP] Implement is [not] distinct from Implement is [not] distinct from Oct 15, 2021
@Dandandan Dandandan requested a review from alamb October 15, 2021 08:33
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me -- nice work @Dandandan !

fyi @xudong963

) -> Result<BooleanArray>
where
T: ArrowNumericType,
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 these look great

@Dandandan Dandandan merged commit 81fae23 into apache:master Oct 15, 2021
@alamb
Copy link
Contributor

alamb commented Oct 15, 2021

🎉

@xudong963
Copy link
Member

@Dandandan Good job!👏

@houqp houqp added the enhancement New feature or request label Nov 6, 2021
unkloud pushed a commit to unkloud/datafusion that referenced this pull request Mar 23, 2025
H0TB0X420 pushed a commit to H0TB0X420/datafusion that referenced this pull request Oct 7, 2025
* fix: recursive import

* format

* format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request sql SQL Planner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants