refactor: fetch statistics for a given ParquetMetaData#10880
Merged
alamb merged 5 commits intoapache:mainfrom Jun 13, 2024
Merged
refactor: fetch statistics for a given ParquetMetaData#10880alamb merged 5 commits intoapache:mainfrom
alamb merged 5 commits intoapache:mainfrom
Conversation
Contributor
Author
|
@alamb : The PR is ready for review |
alamb
approved these changes
Jun 12, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @NGA-TRAN -- this makes sense to me. I took the liberty of
- renaming the function to
statistics_from_parquet_metadataas it isn't fetching anything - adding some more docs
- Simplifiying the test a little
- merging up from main
Contributor
Author
|
Thanks @alamb . Now I know how to write the documentation in DF. Will do that next time |
jeffreyssmith2nd
pushed a commit
to jeffreyssmith2nd/arrow-datafusion
that referenced
this pull request
Jun 14, 2024
* refactor: fetch statistics for a given ParquetMetaData * test: add tests for fetch_statistics_from_parquet_meta * Rename function and improve docs * Simplify the test --------- Co-authored-by: Andrew Lamb <[email protected]>
appletreeisyellow
pushed a commit
to influxdata/arrow-datafusion
that referenced
this pull request
Jun 17, 2024
* refactor: fetch statistics for a given ParquetMetaData * test: add tests for fetch_statistics_from_parquet_meta * Rename function and improve docs * Simplify the test --------- Co-authored-by: Andrew Lamb <[email protected]>
appletreeisyellow
pushed a commit
to influxdata/arrow-datafusion
that referenced
this pull request
Jun 24, 2024
* refactor: fetch statistics for a given ParquetMetaData * test: add tests for fetch_statistics_from_parquet_meta * Rename function and improve docs * Simplify the test --------- Co-authored-by: Andrew Lamb <[email protected]>
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
* refactor: fetch statistics for a given ParquetMetaData * test: add tests for fetch_statistics_from_parquet_meta * Rename function and improve docs * Simplify the test --------- Co-authored-by: Andrew Lamb <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes ##10877
Rationale for this change
In InfluxDB, we want to have a a function similar to fetch_statistics but the given input is not the ObjectStore and ObjectMeta but the ParquetMetaData
What changes are included in this PR?
Refactor fetch_statistics
Are these changes tested?
Yes
Are there any user-facing changes?
No