Merged
Conversation
Contributor
|
The code looks good to me -- I am writing a test for this now. |
alamb
approved these changes
Jun 3, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
I pushed a regression test to this PR too . Looks good to go for me 🚀
Contributor
Author
|
@alamb Thank you for adding the tests! 💯 |
Contributor
|
Thanks for the review @jayzhan211 |
This was referenced Jun 5, 2024
3 tasks
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
* chore: fix regression in `last_value` coercion * Add regression test for first_value / last_value for timestamps * Update for fixed issue * cleanup --------- Co-authored-by: Andrew Lamb <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #10781
Rationale for this change
Fix coercion bug in
last_value()What changes are included in this PR?
Support type signature for numeric string
Are these changes tested?
Yes, tests are added
Are there any user-facing changes?
Yes, users will no longer get an error when query with
last_value()