Implement unparse OuterReferenceColumn to String#10544
Merged
alamb merged 1 commit intoapache:mainfrom May 16, 2024
Merged
Conversation
alamb
approved these changes
May 16, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
LGTM -- thanks @goldmedal
This PR needs to be merged up from main to resolve a conflict if/when you have time
goldmedal
force-pushed
the
feature/10523-outer-column-reference
branch
from
1551cb7 to
baeb3f6
Compare
Contributor
|
Thanks again @goldmedal |
Contributor
Author
|
Thanks @alamb ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #10523
Rationale for this change
IMO,
OuterReferenceColumnis a column can be resolved to an outside field of the current plan. Typically, it's produced fromidentifierorcompound_identifier.datafusion/datafusion/sql/src/expr/identifier.rs
Lines 64 to 69 in 7535d93
I think we can just convert it to a
columnsql node. Just like other identifier. Because the concept ofouter referenceis a logical plan concept, we can ignore the type of aOuterReferenceColumnwhich produced by a field resolving.What changes are included in this PR?
Convert
OuterReferenceColumnto a Column SQL node.Are these changes tested?
Yes
Are there any user-facing changes?
No