feat: Add CrossJoin match case to unparser#10371
Merged
alamb merged 2 commits intoapache:mainfrom May 5, 2024
paradedb:unparser-crossjoin
Merged
feat: Add CrossJoin match case to unparser#10371alamb merged 2 commits intoapache:mainfrom paradedb:unparser-crossjoin
alamb merged 2 commits intoapache:mainfrom
paradedb:unparser-crossjoin
Conversation
Contributor
|
CI failure seems to be infrastructure related: https://github.com/apache/datafusion/actions/runs/8943389816/job/24568207362?pr=10371 -- I restarted it |
alamb
approved these changes
May 3, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Looks good to me -- thank you @sardination
| let sql_to_rel = SqlToRel::new(&context); | ||
| let plan = sql_to_rel.sql_statement_to_plan(statement).unwrap(); | ||
|
|
||
| let roundtrip_statement = plan_to_sql(&plan)?; |
Contributor
|
Thanks again @sardination ! |
This was referenced May 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #8661
Rationale for this change
Came across this issue when trying to federate a query selecting from multiple tables with different sources. For example,
SELECT a_1, b_1 FROM table_a, table_bis evaluated as a cross join, but the unparser wasn't handling cross joins yet.What changes are included in this PR?
Allow unparsing of cross joins into the equivalent inner join.
Are these changes tested?
Added a test for cross join roundtrip. It is slightly different from the other roundtrips because
sqlparserdoesn't have an implementation for Cross Join, so it gets converted into an Inner Join.Are there any user-facing changes?