Conversation
tisonkun
commented
Apr 28, 2024
e5cd047 to
ec88d22
Compare
andygrove
reviewed
Apr 28, 2024
Member
Author
|
@andygrove Updated. It should be fine to merge now. And perhaps our release manual should contain a step to update the download page with the latest version link. |
sebbASF
reviewed
Apr 28, 2024
Signed-off-by: tison <[email protected]>
sebbASF
approved these changes
Apr 28, 2024
phillipleblanc
approved these changes
Apr 29, 2024
Contributor
phillipleblanc
left a comment
There was a problem hiding this comment.
Thanks for this! I have some minor rewording suggestions.
Co-authored-by: Phillip LeBlanc <[email protected]>
Member
Author
|
@phillipleblanc Thank you! Integrated. |
comphead
reviewed
Apr 29, 2024
Member
Author
Co-authored-by: Andrew Lamb <[email protected]> Signed-off-by: tison <[email protected]>
Contributor
|
Looks great to me -- thank you @tisonkun @phillipleblanc @andygrove @sebbASF and @comphead -- a very nice new page indeed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #10236