Conversation
Signed-off-by: tison <[email protected]>
| </description> | ||
| <bug-database rdf:resource="https://github.com/apache/datafusion/issues" /> | ||
| <mailing-list rdf:resource="https://lists.apache.org/[email protected]" /> | ||
| <download-page rdf:resource="https://github.com/apache/datafusion/releases" /> |
There was a problem hiding this comment.
We don't have a download page actually, and I suggest we should create one.
There was a problem hiding this comment.
The official releases will be on the apache download site https://downloads.apache.org/datafusion/ (they are currently on https://downloads.apache.org/arrow/)
However I think the vast majority of datafusion users will get datafusion via crates.io or a direct github link 🤔 I wonder if other types of releases / release page are needed
Any thoughts @andygrove ?
There was a problem hiding this comment.
This is a good question. We may omit this attribute right now.
The situation is somehow complicated due to the existing ASF policies, which make some assumptions in the old days.
Here is the policy: https://infra.apache.org/release-download-pages.html
You can see a formal Download page has a lot of requirements to follow. But for DataFusion, most users just use cargo add datafusion and never care if such a page exists.
We recently had a discussion on the [email protected] for related topics; while I understand your suggestion here, and we should do what is helpful for our users.
However, Arrow has a release/download page, and I check it meets all the requirements. So if people in DataFusion have time to implement it, we can avoid any further concern.
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you so much @tisonkun 🙏 This looks great
I left a few comments / suggestions, but we could also do them as follow ons
Once we merge this PR I will follow the instructions in https://projects.apache.org/create.html to change the apache site (I think it needs to be a PMC member to do this)
| </description> | ||
| <bug-database rdf:resource="https://github.com/apache/datafusion/issues" /> | ||
| <mailing-list rdf:resource="https://lists.apache.org/[email protected]" /> | ||
| <download-page rdf:resource="https://github.com/apache/datafusion/releases" /> |
There was a problem hiding this comment.
The official releases will be on the apache download site https://downloads.apache.org/datafusion/ (they are currently on https://downloads.apache.org/arrow/)
However I think the vast majority of datafusion users will get datafusion via crates.io or a direct github link 🤔 I wonder if other types of releases / release page are needed
Any thoughts @andygrove ?
Co-authored-by: Andrew Lamb <[email protected]>
|
I think we can merge it as is now. There is no blocker, and we can keep improving if any other good suggestions are made. |
I agree -- thank you @tisonkun and @andygrove |
|
I added what I think is the entry. See #10133 (comment) -- will keep that updated |
* chore: Create a doap file Signed-off-by: tison <[email protected]> * Apply suggestions from code review Co-authored-by: Andrew Lamb <[email protected]> --------- Signed-off-by: tison <[email protected]> Co-authored-by: Andrew Lamb <[email protected]>
3 participants
This closes #10133.
cc @alamb