Update .asf.yaml to publish docs to datafusion.apache.org#10190
Update .asf.yaml to publish docs to datafusion.apache.org#10190alamb merged 3 commits intoapache:mainfrom
Conversation
github-actions
bot
added
documentation
andygrove
left a comment
andygrove
left a comment
There was a problem hiding this comment.
LGTM. Thanks @phillipleblanc. I think it would be good to wait for @alamb to also review before merging.
Yeah - there are some links to arrow.apache.org/datafusion still leftover in the repo as well - but I also think we should wait on those changes until we confirm this actually publishes to the right place. Also I wasn't able to figure out how to add the redirect from arrow.apache.org/datafusion to datafusion.apache.org. @alamb did you have an idea on how to do that? |
| github: | ||
| description: "Apache DataFusion SQL Query Engine" | ||
| homepage: https://arrow.apache.org/datafusion | ||
| homepage: https://datafusion.apache.org/ |
There was a problem hiding this comment.
It should be https://datafusion.apache.org/datafusion/?
There was a problem hiding this comment.
https://datafusion.apache.org/ will give you:
There was a problem hiding this comment.
After this change it should start publishing to https://datafusion.apache.org without needing the subdirectory 🤞
The only thing I could think of is creating explicit redirect pages for each .html page in https://github.com/apache/arrow-site I agree having redirects will be important (and I m am not sure what will be on https://arrow.apache.org/datafusion/ afterwards). Thus what I think we should do is to merge this PR, see its effects and I'll file a follow on ticket for the next tasks |
|
Thank you for your work / help and reviews @phillipleblanc |
|
Filed #10194 to track redirects |
|
It appears to have worked! https://datafusion.apache.org/ now shows:
|
|
It appears that https://arrow.apache.org/datafusion/ has an older snapshot of the site (as in it was not updated as well):
|
|
I think I have figured out the redirects -- see apache/arrow-site#502 |
* Update .asf.yaml to publish to root * Update website to have top-level ASF links
4 participants
Which issue does this PR close?
Closes #10151
Rationale for this change
What changes are included in this PR?
Updates
.asf.yamlto point to the new top-level website, and adds the required links to the ASF as required by https://www.apache.org/foundation/marks/pmcs#navigationI mirrored what https://arrow.apache.org does and grouped these links into an
ASF LinkssectionAccording to https://github.com/apache/infrastructure-asfyaml/blob/main/README.md#publish - removing the
subdirconfig inpublishwill do what we want.Are these changes tested?
Here is a screenshot of what it looks like locally:
Are there any user-facing changes?
N/A