Skip to content

Move abs to datafusion_functions #9286

Closed

Description

@alamb

Is your feature request related to a problem or challenge?

Part of #9285 and #8045

The goal is to extract function definitions out of the datafusion core.

Describe the solution you'd like

Move the abs function to datafusion-functions

Target location: https://github.com/apache/arrow-datafusion/blob/main/datafusion/functions/src/math

Here is an example function: isnan: https://github.com/apache/arrow-datafusion/blob/e1f7b245168c5762135abc4e594bd81c508d7186/datafusion/functions/src/math/nans.rs#L31-L48

There is already coverage in https://github.com/apache/arrow-datafusion/blob/main/datafusion/sqllogictest/test_files/scalar.slt

Here are the steps I followed when porting isnan:

  1. Create a ScalarUDFImpl in the functions crate following an existing example, and stub out the invoke() function with todo!().
  2. Make sure cargo check -p datafusion-functions --all-features compiles successfully
  3. Remove the enum in BuiltInScalarFunctions (source link)
  4. Try and build with cargo check -p datafusion and the compiler will point out all the places in the code that has logic for this function
  5. While removing old code, copy the relevant parts back into the UDFs (like signature, and return_type and implementation for invoke()
  6. Verify that the sqllogictests pass: `

Describe alternatives you've considered

No response

Additional context

No response

Activity

  1. alamb commented on Feb 20, 2024

    @alamb
    ContributorAuthor

    I have tried to make this as well specified as possible and thus I think it would be a good first issue. However, we don't have a huge list of these functions yet so if you hit a snag let us know

  2. yyy1000 commented on Feb 20, 2024

    @yyy1000
    Contributor

    take

  3. alamb commented on Feb 27, 2024

    @alamb
    ContributorAuthor

    ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions