Skip to content

to_char(.., null) should be NULL, not .. #9217

Closed

Description

@alamb

The newly added to_char's null handling is not quite correct -- specifically when the format string is null, the output should be null, but now it returns the first argument

Goal is to make to_char do what postgres does:

          Postgres seems to think this should be null
postgres=# select to_char(interval '1 day', null);
 to_char
---------

(1 row)

Originally posted by @alamb in #9181 (comment)

Activity

  1. alamb commented on Feb 13, 2024

    @alamb
    ContributorAuthor

    There are existing tests in timestamp.slt, this should simply be a matter of updating the code (see #9181) -- I think this would be a good first issue

  2. manoj-inukolunu commented on Feb 14, 2024

    @manoj-inukolunu
    Contributor

    take

  3. tinfoil-knight commented on Mar 11, 2024

    @tinfoil-knight
    Contributor

    @manoj-inukolunu Are you still working on this? (If not, could you please un-assign yourself. I'd like to attempt the fix for this issue)

  4. manoj-inukolunu commented on Mar 13, 2024

    @manoj-inukolunu
    Contributor

    Hey so sorry not working on it right now , swamped with work .

  5. manoj-inukolunu commented on Mar 13, 2024

    @manoj-inukolunu
    Contributor

    unassign

  6. removed their assignment
    on Mar 13, 2024
  7. tinfoil-knight commented on Mar 13, 2024

    @tinfoil-knight
    Contributor

    take

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

bugSomething isn't workinggood first issueGood for newcomers

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions