-
Notifications
You must be signed in to change notification settings - Fork 2k
Description
Is your feature request related to a problem or challenge?
After I upgraded my application from 28.0.0 to 34.0.0, I noticed that as a result of #7390, it is no longer possible to register your own listing table with a custom file format, because the code that supports writing assumes a fixed list of FileTypes. Specifically, the when implementing FileFormat, the enum must be provided.
Describe the solution you'd like
Ideally FileFormat would not have to return a FileType, and the ability to write to listing tables would be:
- optional
- not coupled to an enumerated list of file types
As it stands currently, it looks like this method is only used to help out code that supports writing, so perhaps it can be refactored to be more coupled with that functionality. I don't have any specific proposal at the moment, but it seems achievable (if it's something maintainers would be okay with).
Describe alternatives you've considered
Several alternatives seem to work for me:
- Give up on
ListingTableas an extensible API and just useTableProviderinstead. This would be disappointing, because it does provide a lot of nice functionality that would have to reimplemented. - Provide a garbage
FileTypeinFileFormat::file_typebecause it doesn't seem to cause problems unless you're trying to write. This is what I'm doing for now.
Additional context
No response