Skip to content

Add serialization for entire LogicalPlans to datafusion-proto #4338

Closed

Description

@alamb

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

In order to serialize subquery expressions (#4337) we would need to serialize entire LogicalPlans which datafusion-proto does not do .

Describe the solution you'd like
I would like to have the ability to serialize / deserialize LogicalPlans in the datafusion. I believe we can take a friendly look / downright copy this code from ballista:

https://github.com/apache/arrow-ballista/blob/acbdf608807697e72122a249c4bf7505274906d0/ballista/core/proto/datafusion.proto

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
#4337

cc @andygrove @thinkharderdev @avantgardnerio

I am marking this as "good first isseu" because I think it would mostly be an exercise in porting code and tests from one repo to another.

Activity

  1. l0kr commented on Mar 9, 2023

    @l0kr
    Contributor

    Let me take a stab at this. @alamb anything changed since this task was created?

  2. alamb commented on Mar 10, 2023

    @alamb
    ContributorAuthor

    THanks @l0kr -- sorry for the old ticket. I think this task is actually is mostly done https://github.com/apache/arrow-datafusion/tree/main/datafusion/proto/src/logical_plan

    It would be very valuable if you were able to go through and fill out the various "Not implemented" in the plan conversion.

    Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions