Skip to content

Add subquery support in datafusion-proto #2640

Open

Description

@andygrove

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Once #2639 is merged we should add support for serializing plans that contain subquery expressions.

This will likely require breaking changes to the API because we currently have one API for Expr that optionally accepts a FunctionRegistry and one API for LogicalPlan that optionally accepts a LogicalExtensionCodec. With subquery support we have plans referencing expressions and expressions referencing plans, so these APIs will need to be combined somehow.

Here is a suggestion for the new API from the discussion at #2639 (comment)

let bytes = PlanSerializer::new()
    .with_extension_codec(&extension_codec)
   .serialize()?;

Describe the solution you'd like
TBD

Describe alternatives you've considered
None

Additional context
None

Activity

  1. liukun4515 commented on May 30, 2022

    @liukun4515
    Contributor

    feature of the subquery is needed in my system, I can figure out this issue.
    @andygrove

  2. alamb commented on May 30, 2022

    @alamb
    Contributor

    When we implement this feature, it might be worth considering a slightly more encapsulated API for serializing / deserializing plans, as described in #2639 (comment)

  3. andygrove commented on May 31, 2022

    @andygrove
    MemberAuthor

    I have a PR up (#2670) with a proposal for the API part

  4. alamb commented on Nov 23, 2022

    @alamb
    Contributor

    Possibly duplicated by #2646

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requesthelp wantedExtra attention is needed

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions