Skip to content

Deprecate PruningPredicate::try_new in favor of PruningPredicateBuilder #24128

Closed

Description

@zhuqi-lucas

Follow-up to #24074, per @alamb's suggestion.

#24074 introduced PruningPredicateBuilder (.with_file_schema(...), .with_error_counter(...), .with_max_in_list_size(...), .build(...)/.try_build(...)) as the extensible entry point for constructing a PruningPredicate.

As a follow-up we should:

  • Point people at PruningPredicateBuilder from the PruningPredicate::try_new doc comment.
  • Deprecate PruningPredicate::try_new (#[deprecated]) and migrate its call sites to the builder.
  • Move the construction logic into the builder so there is a single place to add future parameters.

Non-blocking cleanup — no behavior change.

Activity

  1. goutamadwant commented on Aug 6, 2026

    @goutamadwant
    Contributor

    take

  2. added a commit that references this issue on Aug 6, 2026
  3. goutamadwant commented on Aug 6, 2026

    @goutamadwant
    Contributor

    Opened #24129 . This moves pruning predicate construction into PruningPredicateBuilder, deprecates PruningPredicate::try_new, and migrates DataFusion's internal call sites and examples. The deprecated constructor remains as a compatibility wrapper with unchanged behavior.

  4. added a commit that references this issue on Aug 7, 2026
  5. added a commit that references this issue on Aug 7, 2026
    f05869b
  6. added a commit that references this issue on Aug 12, 2026
    d68c2a5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions