Skip to content

Add Poll::Pending spill stream test coverage for SMJ async spill paths #22879

Closed

Description

@pantShrey

Follow-up to #22230

The materializing_stream and bitwise_stream async spill read paths (introduced in the refactor) needs test coverage that forces read_spill_as_stream to yield Poll::Pending mid-read to exercise the re-entry logic.

This should become significantly easier once #21882 lands, as a mock spill implementation can inject Poll::Pending without requiring changes to internal stream construction.

Activity

  1. kumarUjjawal commented on Jun 12, 2026

    @kumarUjjawal
    Contributor

    @pantShrey would you be interested in opening a PR for this? I can review.

  2. pantShrey commented on Jun 12, 2026

    @pantShrey
    ContributorAuthor

    @kumarUjjawal Thank you for offering I would be happy to work on it! Once #21882 merges I will try to land this PR fast as well

  3. pantShrey commented on Jul 6, 2026

    @pantShrey
    ContributorAuthor

    @kumarUjjawal extremely sorry for the delay on this! The PR is finally up here: #23353.

  4. added a commit that references this issue on Jul 11, 2026
    f269b94
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions