Skip to content

Optimize approx_distinct() for strings #21035

Description

@neilconway

Is your feature request related to a problem or challenge?

approx_distinct is approximately 25 times slower for strings than for integers on my machine, which is a bit surprising. Seems like we're doing some unnecessary copying that can be easily avoided.

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

No response

Activity

  1. neilconway commented on Mar 18, 2026

    @neilconway
    ContributorAuthor

    take

  2. changed the title [-]Optimize approx_distinct() for strings[/-] [+]Optimize `approx_distinct()` for strings[/+] on Mar 18, 2026
  3. added a commit that references this issue on Mar 18, 2026
    317052e
  4. added a commit that references this issue on Mar 24, 2026
    8f3bdb1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions