Repository navigation
Improve performance of ScalarValue::add #20933
Description
I bet you can make this even faster by making it mutate lhs rather than make a new one
pub(crate) fn scalar_add(lhs: &mut ScalarValue, rhs: &ScalarValue) -> Result<()> {Originally posted by @alamb in #20768 (comment)
The other idea is to inline the implementation of precision_add to ScalarValue::add for numeric types, in order to avoid allocations when adding
Activity
perf: add in-place fast path for ScalarValue::add (#20959)
perf: add in-place fast path for ScalarValue::add (apache#20959)
perf: add in-place fast path for ScalarValue::add (apache#20959)