Skip to content

Type signature matching errors are overly verbose and show internal details #20501

Open

Description

@kallisti-dev

Description

After upgrading to DataFusion 52, error messages for function signature mismatches have become less concise and helpful. When a user tries to call an aggregate function with an unsupported type, they now see verbose internal errors instead of user-friendly messages.

This regression was introduced in PR #18769 ("Refactor avg & sum signatures away from user defined"), which was part of the broader effort in #12725 to avoid use of Signature::user_defined.

To Reproduce

CREATE TABLE test (bool_col BOOLEAN);
SELECT SUM(bool_col) FROM test;

Before (DataFusion 51):

Error during planning: Execution error: Function 'sum' user-defined coercion failed with "Execution error: Sum not supported for Boolean" No function matches the given name and argument types 'sum(Boolean)'. You might need to add explicit type casts.
	Candidate functions:
	sum(UserDefined)

The key message "Sum not supported for Boolean" was clear and actionable.

After (DataFusion 52):

Error during planning: Internal error: Function 'sum' failed to match any signature, errors: Internal error: Expect TypeSignatureClass::Decimal but received NativeType::Boolean, DataType: Boolean.
This issue was likely caused by a bug in DataFusion's code. Please help us to resolve this by filing a bug report in our issue tracker: https://github.com/apache/datafusion/issues,Internal error: Expect TypeSignatureClass::Native(LogicalType(Native(UInt64), UInt64)) but received NativeType::Boolean, DataType: Boolean.
This issue was likely caused by a bug in DataFusion's code...
[repeats for each signature variant]
	Candidate functions:
	sum(Coercion(TypeSignatureClass::Decimal))
	sum(Coercion(TypeSignatureClass::Native(LogicalType(Native(UInt64), UInt64)), implicit_coercion=...))
	...

Problems With New Error

  1. Misleading: Says "Internal error" and asks users to file a bug report, but this is a user error (wrong argument type), not a DataFusion bug
  2. Verbose: Shows every failed signature match attempt with internal type system details (TypeSignatureClass::Native(LogicalType(...)))
  3. Lost context: The meaningful message "Sum not supported for Boolean" is no longer present

Activity

  1. alamb commented on Feb 23, 2026

    @alamb
    Contributor

    I think this might be related to some changes @Jefffrey might remember 🤔

  2. Jefffrey commented on Mar 2, 2026

    @Jefffrey
    Contributor

    Yeah #20070 (and the linked issues inside it) is meant to work towards solving this (along with #20605 it seems)

  3. myandpr commented on Mar 18, 2026

    @myandpr
    Contributor

    Hi @Jefffrey @alamb I spent a bit of time looking at this.

    The immediate problem seems to be that TypeSignature::OneOf turns overload/coercion failures into an Internal error, which then becomes user-visible during planning.

    Would it make sense to return a normal planning error here instead, while keeping the existing candidate-signature diagnostics?

    That would not fully restore the older Sum not supported for Boolean wording, but it should address the misleading internal-error behavior and the exposed internal type details.

    Would it also make sense to look at this implementation? #21032

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions