Repository navigation
Make PhysicalExprAdapterFactory::create fallible #19956
Description
Currently, the PhysicalExprAdapterFactory::create method is infallible (does not return errors). However, we encode certain metadata in the physical file schema, and decoding this metadata is a fallible operation. Therefore, I propose making PhysicalExprAdapterFactory::create fallible to allow proper error propagation.
Reacted by Adrian Garcia Badaracco
Activity
adriangb commentedon Jan 23, 2026
I think this is reasonable. Of course not everyone is going to have this use case but I think it makes sense to support it for those that do. Does it force any of the call sites in DataFusion to change? I.e. how invasive is the change going to be?
niebayes commentedon Jan 26, 2026
@adriangb Since the return type is changed, callers of
PhysicalExprAdapterFactory::createwill be affected and I think this is a breaking change. However, this change is not invasive as it only changes the return type.adriangb commentedon Jan 26, 2026
Ok let's see a PR diff and go from there!
niebayes commentedon Jan 27, 2026
@adriangb Filed a PR, PTAL.
refactor: make PhysicalExprAdatperFactory::create fallible (#20017)
refactor: make PhysicalExprAdatperFactory::create fallible (apache#20017