-
Notifications
You must be signed in to change notification settings - Fork 2k
Closed
Description
Description:
When running the Substrait tests with DataFusion built without the unicode_expressions feature (in datafusion/substrait/Cargo.toml only nested_expressions is enabled), the cases::roundtrip_logical_plan::simple_scalar_function_substr test fails with:
NotImplemented("Substring could not be planned by registered expr planner. Hint: enable the unicode_expressions")
Concretely:
- The UnicodeFunctionPlanner is not registered because the
unicode_expressionsfeature is disabled. - As a result, the
SUBSTR/substringfunction cannot be planned under the Substrait logical plan conversion. - This causes the
simple_scalar_function_substrround‐trip logical plan test to fail under those build settings.
Steps to reproduce:
- Checkout the DataFusion repo.
- Build without
unicode_expressions(so that onlynested_expressionsis enabled in the Substrait feature set). - Run the Substrait tests —
cargo test -p datafusion-substrait --test substrait_integrationor specificallycases::roundtrip_logical_plan::simple_scalar_function_substr - Observe the failure:
NotImplemented("Substring could not be planned by registered expr planner. Hint: enable the unicode_expressions").
Expected behavior:
Either
- The Substr /
substringfunction should be plannable even whenunicode_expressionsis disabled (i.e. provide a fallback planner / expression implementation), or - At least the test suite should skip or mark this as expected behavior when
unicode_expressionsis off, rather than failing.
References:
- The error message:
Substring could not be planned by registered expr planner. Hint: enable the unicode_expressions - The failing test:
cases::roundtrip_logical_plan::simple_scalar_function_substr
Issue was discovered in this PR comment - #17468 (comment)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels